qidaye commented on code in PR #43114:
URL: https://github.com/apache/doris/pull/43114#discussion_r1827324447
##########
be/test/olap/segcompaction_test.cpp:
##########
@@ -830,6 +849,51 @@ TEST_F(SegCompactionTest,
SegCompactionThenReadUniqueTableSmall) {
}
}
+TEST_F(SegCompactionTest, CreateSegCompactionWriter) {
+ config::enable_segcompaction = true;
+ Status s;
+ TabletSchemaSPtr tablet_schema = std::make_shared<TabletSchema>();
+ TabletSchemaPB schema_pb;
+ schema_pb.set_keys_type(KeysType::DUP_KEYS);
+
schema_pb.set_inverted_index_storage_format(InvertedIndexStorageFormatPB::V2);
+
+ construct_column(schema_pb.add_column(), schema_pb.add_index(), 10000,
"key_index", 0, "INT",
+ "key");
+ construct_column(schema_pb.add_column(), schema_pb.add_index(), 10001,
"v1_index", 1, "STRING",
+ "v1");
+ construct_column(schema_pb.add_column(), schema_pb.add_index(), 10002,
"v2_index", 2, "STRING",
+ "v2", true);
+ construct_column(schema_pb.add_column(), schema_pb.add_index(), 10003,
"v3_index", 3, "INT",
+ "v3");
+
+ tablet_schema.reset(new TabletSchema);
+ tablet_schema->init_from_pb(schema_pb);
+ RowsetSharedPtr rowset;
+ config::segcompaction_candidate_max_rows = 6000; // set threshold above
+ // rows_per_segment
+ config::segcompaction_batch_size = 3;
+ std::vector<uint32_t> segment_num_rows;
+ {
+ RowsetWriterContext writer_context;
+ create_rowset_writer_context(10052, tablet_schema, &writer_context);
+
+ auto res = RowsetFactory::create_rowset_writer(*l_engine,
writer_context, false);
+ EXPECT_TRUE(res.has_value()) << res.error();
+ auto rowset_writer = std::move(res).value();
+ EXPECT_EQ(Status::OK(), s);
Review Comment:
Redundant？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
