gavinchou commented on code in PR #43060:
URL: https://github.com/apache/doris/pull/43060#discussion_r1827950967
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/property/constants/S3Properties.java:
##########
@@ -334,6 +335,18 @@ public static Cloud.ObjectStoreInfoPB.Builder
getObjStoreInfoPB(Map<String, Stri
// S3 Provider properties should be case insensitive.
builder.setProvider(Provider.valueOf(properties.get(S3Properties.PROVIDER).toUpperCase()));
}
+
+ if (properties.containsKey(PropertyConverter.USE_PATH_STYLE)) {
+ String value = properties.get(PropertyConverter.USE_PATH_STYLE);
+ Preconditions.checkArgument(!Strings.isNullOrEmpty(value),
"use_path_style cannot be empty");
+ Preconditions.checkArgument(value.equalsIgnoreCase("true")
+ || value.equalsIgnoreCase("false"), "Invalid
use_path_style value: %s", value);
+ if
(properties.get(PropertyConverter.USE_PATH_STYLE).equalsIgnoreCase("true")) {
+ builder.setUsePathStyle(true);
+ } else {
+ builder.setUsePathStyle(false);
+ }
Review Comment:
```suggestion
builder.setUsePathStyle(value.equalsIgnoreCase("true"));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
