Mryange commented on code in PR #42930:
URL: https://github.com/apache/doris/pull/42930#discussion_r1828660022
##########
be/src/vec/exprs/vbitmap_predicate.cpp:
##########
@@ -90,14 +87,14 @@ doris::Status
vectorized::VBitmapPredicate::execute(vectorized::VExprContext* co
arguments[i] = column_id;
}
// call function
- size_t num_columns_without_result = block->columns();
+ uint32_t num_columns_without_result = block->columns();
auto res_data_column = ColumnVector<UInt8>::create(block->rows());
ColumnPtr argument_column =
block->get_by_position(arguments[0]).column->convert_to_full_column_if_const();
size_t sz = argument_column->size();
res_data_column->resize(sz);
- auto ptr =
((ColumnVector<UInt8>*)res_data_column.get())->get_data().data();
+ auto* ptr =
((ColumnVector<UInt8>*)res_data_column.get())->get_data().data();
Review Comment:
why type conversion here
```suggestion
auto* ptr =
((ColumnVector<UInt8>*)res_data_column.get())->get_data().data();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
