HappenLee commented on code in PR #43228:
URL: https://github.com/apache/doris/pull/43228#discussion_r1828737241
##########
be/src/vec/columns/column_complex.h:
##########
@@ -81,7 +81,8 @@ class ColumnComplexType final : public COWHelper<IColumn,
ColumnComplexType<T>>
} else if constexpr (std::is_same_v<T, QuantileStateDouble>) {
pvalue->deserialize(Slice(pos, length));
} else {
- LOG(FATAL) << "Unexpected type in column complex";
+ throw doris::Exception(ErrorCode::INTERNAL_ERROR, "Unexpected type
in column complex");
+ __builtin_unreachable();
Review Comment:
the func is void， seems no need add `__builtin_unreachable()`
##########
be/src/vec/columns/column_complex.h:
##########
@@ -124,12 +125,14 @@ class ColumnComplexType final : public COWHelper<IColumn,
ColumnComplexType<T>>
[[noreturn]] void get_permutation(bool reverse, size_t limit, int
nan_direction_hint,
IColumn::Permutation& res) const
override {
- LOG(FATAL) << "get_permutation not implemented";
+ throw doris::Exception(ErrorCode::INTERNAL_ERROR, "get_permutation not
implemented");
+ __builtin_unreachable();
Review Comment:
same to the up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
