zhangstar333 commented on code in PR #8525:
URL: https://github.com/apache/incubator-doris/pull/8525#discussion_r865889630
##########
be/src/exec/parquet_writer.cpp:
##########
@@ -443,9 +480,333 @@ Status ParquetWriterWrapper::_write_one_row(TupleRow*
row) {
break;
}
default: {
- std::stringstream ss;
- ss << "unsupported file format: " <<
_output_expr_ctxs[index]->root()->type().type;
- return Status::InvalidArgument(ss.str());
+ fmt::memory_buffer err_ss;
+ fmt::format_to(err_ss, "unsupported file format: : {}.",
+
(*_output_vexpr_ctxs)[index]->root()->type().type);
+ return Status::InvalidArgument(fmt::to_string(err_ss.data()));
+ }
+ }
+ }
+ } catch (const std::exception& e) {
+ LOG(WARNING) << "Parquet write error: " << e.what();
+ return Status::InternalError(e.what());
+ }
+ return Status::OK();
+}
+
+Status ParquetWriterWrapper::_write_one_row(vectorized::Block& block, size_t
row) {
+ int num_columns = _output_vexpr_ctxs->size();
Review Comment:
Now this implementation is based on row, the performance may not be good, so
it need to be change write data by column after have another plan about
vectorized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
