yiguolei commented on code in PR #9368:
URL: https://github.com/apache/incubator-doris/pull/9368#discussion_r866535080
##########
be/src/olap/tablet_manager.cpp:
##########
@@ -1272,11 +1185,19 @@ Status
TabletManager::_create_tablet_meta_unlocked(const TCreateTabletReq& reque
RETURN_NOT_OK_LOG(store->get_shard(&shard_id), "fail to get root path
shard");
Status res = TabletMeta::create(request, TabletUid::gen_uid(), shard_id,
next_unique_id,
col_idx_to_unique_id, tablet_meta);
-
- if (request.__isset.storage_format && request.storage_format !=
TStorageFormat::V1) {
- (*tablet_meta)->set_preferred_rowset_type(BETA_ROWSET);
- } else {
- (*tablet_meta)->set_preferred_rowset_type(ALPHA_ROWSET);
+ RETURN_NOT_OK(res);
+ if (request.__isset.storage_format) {
Review Comment:
If storage format is not set, then _preferred_rowset_type == BETA_ROWSET
according to the definition in
RowsetTypePB _preferred_rowset_type = BETA_ROWSET; in tablet_meta.h
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
