github-actions[bot] commented on code in PR #41994:
URL: https://github.com/apache/doris/pull/41994#discussion_r1831369790


##########
be/src/agent/heartbeat_server.cpp:
##########
@@ -291,8 +306,8 @@ Status HeartbeatServer::_heartbeat(const TMasterInfo& 
master_info) {
 
 Status create_heartbeat_server(ExecEnv* exec_env, uint32_t server_port,
                                std::unique_ptr<ThriftServer>* thrift_server,
-                               uint32_t worker_thread_num, TMasterInfo* 
local_master_info) {
-    HeartbeatServer* heartbeat_server = new HeartbeatServer(local_master_info);
+                               uint32_t worker_thread_num, ClusterInfo* 
cluster_info) {
+    HeartbeatServer* heartbeat_server = new HeartbeatServer(cluster_info);

Review Comment:
   warning: use auto when initializing with new to avoid duplicating the type 
name [modernize-use-auto]
   
   ```suggestion
       auto* heartbeat_server = new HeartbeatServer(cluster_info);
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to