This is an automated email from the ASF dual-hosted git repository.
w41ter pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.1 by this push:
new 80de533b7c7 [improve](backup) Only compress the running backup/restore
job #43177 #43278 (#43487)
80de533b7c7 is described below
commit 80de533b7c7c713b7f3a86335cef55267bc905e6
Author: walter <[email protected]>
AuthorDate: Fri Nov 8 14:10:53 2024 +0800
[improve](backup) Only compress the running backup/restore job #43177
#43278 (#43487)
cherry pick from #43278
---
fe/fe-core/src/main/java/org/apache/doris/backup/BackupJob.java | 8 ++++++--
fe/fe-core/src/main/java/org/apache/doris/backup/RestoreJob.java | 8 ++++++--
2 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/fe/fe-core/src/main/java/org/apache/doris/backup/BackupJob.java
b/fe/fe-core/src/main/java/org/apache/doris/backup/BackupJob.java
index fdcc4892778..32b65b013da 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/backup/BackupJob.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/backup/BackupJob.java
@@ -1066,11 +1066,15 @@ public class BackupJob extends AbstractJob {
@Override
public void write(DataOutput out) throws IOException {
- if (Config.backup_job_compressed_serialization) {
+ // For a completed job, there's no need to save it with compressed
serialization as it has
+ // no snapshot or backup meta info, making it small in size. This
helps maintain compatibility
+ // more easily.
+ boolean shouldCompress = !isDone() &&
Config.backup_job_compressed_serialization;
+ if (shouldCompress) {
type = JobType.BACKUP_COMPRESSED;
}
super.write(out);
- if (Config.backup_job_compressed_serialization) {
+ if (shouldCompress) {
type = JobType.BACKUP;
int written = 0;
diff --git a/fe/fe-core/src/main/java/org/apache/doris/backup/RestoreJob.java
b/fe/fe-core/src/main/java/org/apache/doris/backup/RestoreJob.java
index 68e3331b71e..0bca5ef4dd4 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/backup/RestoreJob.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/backup/RestoreJob.java
@@ -2498,11 +2498,15 @@ public class RestoreJob extends AbstractJob {
@Override
public void write(DataOutput out) throws IOException {
- if (Config.restore_job_compressed_serialization) {
+ // For a completed job, there's no need to save it with compressed
serialization as it has
+ // no snapshot or backup meta info, making it small in size. This
helps maintain compatibility
+ // more easily.
+ boolean shouldCompress = !isDone() &&
Config.restore_job_compressed_serialization;
+ if (shouldCompress) {
type = JobType.RESTORE_COMPRESSED;
}
super.write(out);
- if (Config.restore_job_compressed_serialization) {
+ if (shouldCompress) {
type = JobType.RESTORE;
int written = 0;
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
