freemandealer opened a new pull request, #43512:
URL: https://github.com/apache/doris/pull/43512
pick #43220 pick #43220 pick #43220
Previously, cache blocks could be downloaded as different types than the
target type we intended to read, leading to false cache misses. E.g., a block
might be downloaded as an 'idx' type when the current context expected a 'ttl'
type.
The root cause of this problem is the original design encoding meta info
such as type and expiration time into cache block file path and readers of this
cache block file have inconsistent view of the type so they use different name
to locate file and run into error in the end.
This commit tries other type if the initial type failed to locate the file
(return NOT_FOUND). Be ware that this is a nasty quick fix. We will elimite the
metadate encoded in the file path in the near future to get rid of all the path
related problems.
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
