github-actions[bot] commented on code in PR #43517:
URL: https://github.com/apache/doris/pull/43517#discussion_r1833986318
##########
be/src/exprs/runtime_filter.cpp:
##########
@@ -1054,30 +1053,33 @@ class SyncSizeClosure : public
AutoReleaseClosure<PSendFilterSizeRequest,
// context, it not the memory is not released. And rpc is in another
thread, it will hold rf context
// after query context because the rpc is not returned.
std::weak_ptr<RuntimeFilterContext> _rf_context;
- std::string _rf_debug_info;
using Base =
AutoReleaseClosure<PSendFilterSizeRequest,
DummyBrpcCallback<PSendFilterSizeResponse>>;
ENABLE_FACTORY_CREATOR(SyncSizeClosure);
+ ~SyncSizeClosure() override {
((pipeline::CountedFinishDependency*)_dependency.get())->sub(); }
Review Comment:
warning: use '= default' to define a trivial destructor
[modernize-use-equals-default]
```cpp
~SyncSizeClosure() override {
((pipeline::CountedFinishDependency*)_dependency.get())->sub(); }
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
