dataroaring commented on code in PR #43574:
URL: https://github.com/apache/doris/pull/43574#discussion_r1836018689
##########
be/src/olap/rowset/vertical_beta_rowset_writer.cpp:
##########
@@ -50,7 +50,8 @@ template <class T>
requires std::is_base_of_v<BaseBetaRowsetWriter, T>
Status VerticalBetaRowsetWriter<T>::add_columns(const vectorized::Block* block,
const std::vector<uint32_t>&
col_ids, bool is_key,
- uint32_t max_rows_per_segment)
{
+ uint32_t max_rows_per_segment,
+ bool has_cluster_key) {
Review Comment:
And it would generates too many segments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
