yiguolei commented on code in PR #42006:
URL: https://github.com/apache/doris/pull/42006#discussion_r1836516216


##########
be/src/runtime/workload_group/workload_group.cpp:
##########
@@ -561,15 +579,24 @@ void 
WorkloadGroup::upsert_task_scheduler(WorkloadGroupInfo* tg_info, ExecEnv* e
             } else {
                 LOG(INFO) << "[upsert wg thread pool] enable cpu hard limit 
but value is "
                              "illegal: "
-                          << cpu_hard_limit << ", gid=" << tg_id;
+                          << cpu_hard_limit << ", gid=" << wg_id;
             }
         } else {
             _cgroup_cpu_ctl->update_cpu_soft_limit(cpu_shares);
             _cgroup_cpu_ctl->update_cpu_hard_limit(
                     CPU_HARD_LIMIT_DEFAULT_VALUE); // disable cpu hard limit
         }
-        _cgroup_cpu_ctl->get_cgroup_cpu_info(&(tg_info->cgroup_cpu_shares),
-                                             
&(tg_info->cgroup_cpu_hard_limit));
+        _cgroup_cpu_ctl->get_cgroup_cpu_info(&(wg_info->cgroup_cpu_shares),
+                                             
&(wg_info->cgroup_cpu_hard_limit));
+    }
+}
+
+void WorkloadGroup::upsert_task_scheduler(WorkloadGroupInfo* wg_info) {

Review Comment:
   why the input parameter is a pointer??



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to