Gabriel39 commented on code in PR #9440:
URL: https://github.com/apache/incubator-doris/pull/9440#discussion_r867473767
##########
fe/java-udf/src/main/java/org/apache/doris/udf/UdfExecutor.java:
##########
@@ -365,41 +445,81 @@ private void allocateInputObjects(long row) throws
UdfRuntimeException {
for (int i = 0; i < argTypes_.length; ++i) {
switch (argTypes_[i]) {
case BOOLEAN:
- inputObjects_[i] = UdfUtils.UNSAFE.getBoolean(null,
UdfUtils.UNSAFE.getLong(null, UdfUtils.getAddressAtOffset(inputBufferPtrs_, i))
+ row);
+ inputObjects_[i] = UdfUtils.UNSAFE.getBoolean(null,
+ UdfUtils.UNSAFE.getLong(null,
UdfUtils.getAddressAtOffset(inputBufferPtrs_, i)) + row);
break;
case TINYINT:
- inputObjects_[i] = UdfUtils.UNSAFE.getByte(null,
UdfUtils.UNSAFE.getLong(null, UdfUtils.getAddressAtOffset(inputBufferPtrs_, i))
+ row);
+ inputObjects_[i] = UdfUtils.UNSAFE.getByte(null,
+ UdfUtils.UNSAFE.getLong(null,
UdfUtils.getAddressAtOffset(inputBufferPtrs_, i)) + row);
break;
case SMALLINT:
- inputObjects_[i] = UdfUtils.UNSAFE.getShort(null,
UdfUtils.UNSAFE.getLong(null, UdfUtils.getAddressAtOffset(inputBufferPtrs_, i))
+ 2L * row);
+ inputObjects_[i] = UdfUtils.UNSAFE.getShort(null,
+ UdfUtils.UNSAFE.getLong(null,
UdfUtils.getAddressAtOffset(inputBufferPtrs_, i)) + 2L * row);
break;
case INT:
- inputObjects_[i] = UdfUtils.UNSAFE.getInt(null,
UdfUtils.UNSAFE.getLong(null, UdfUtils.getAddressAtOffset(inputBufferPtrs_, i))
+ 4L * row);
+ inputObjects_[i] = UdfUtils.UNSAFE.getInt(null,
+ UdfUtils.UNSAFE.getLong(null,
UdfUtils.getAddressAtOffset(inputBufferPtrs_, i)) + 4L * row);
break;
case BIGINT:
- inputObjects_[i] = UdfUtils.UNSAFE.getLong(null,
UdfUtils.UNSAFE.getLong(null, UdfUtils.getAddressAtOffset(inputBufferPtrs_, i))
+ 8L * row);
+ inputObjects_[i] = UdfUtils.UNSAFE.getLong(null,
+ UdfUtils.UNSAFE.getLong(null,
UdfUtils.getAddressAtOffset(inputBufferPtrs_, i)) + 8L * row);
break;
case FLOAT:
- inputObjects_[i] = UdfUtils.UNSAFE.getFloat(null,
UdfUtils.UNSAFE.getLong(null, UdfUtils.getAddressAtOffset(inputBufferPtrs_, i))
+ 4L * row);
+ inputObjects_[i] = UdfUtils.UNSAFE.getFloat(null,
+ UdfUtils.UNSAFE.getLong(null,
UdfUtils.getAddressAtOffset(inputBufferPtrs_, i)) + 4L * row);
break;
case DOUBLE:
- inputObjects_[i] = UdfUtils.UNSAFE.getDouble(null,
UdfUtils.UNSAFE.getLong(null, UdfUtils.getAddressAtOffset(inputBufferPtrs_, i))
+ 8L * row);
+ inputObjects_[i] = UdfUtils.UNSAFE.getDouble(null,
+ UdfUtils.UNSAFE.getLong(null,
UdfUtils.getAddressAtOffset(inputBufferPtrs_, i)) + 8L * row);
+ break;
+ case DATE: {
+ long data = UdfUtils.UNSAFE.getLong(null,
+ UdfUtils.UNSAFE.getLong(null,
UdfUtils.getAddressAtOffset(inputBufferPtrs_, i)) + 8L * row);
+ inputObjects_[i] = convertToDate(data);
+ break;
+ }
+ case DATETIME: {
+ long data = UdfUtils.UNSAFE.getLong(null,
+ UdfUtils.UNSAFE.getLong(null,
UdfUtils.getAddressAtOffset(inputBufferPtrs_, i)) + 8L * row);
+ inputObjects_[i] = convertToDateTime(data);
+ break;
+ }
+ case LARGEINT: {
+ long base =
+ UdfUtils.UNSAFE.getLong(null,
UdfUtils.getAddressAtOffset(inputBufferPtrs_, i)) + 16L * row;
+ byte[] bytes = new byte[16];
+ UdfUtils.copyMemory(null, base, bytes,
UdfUtils.BYTE_ARRAY_OFFSET, 16);
+
+ inputObjects_[i] = new BigInteger(convertByteOrder(bytes));
+ break;
+ }
+ case DECIMALV2: {
Review Comment:
better to add some UTs in org.apache.doris.udf.UdfExecutorTest for these
complex types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
