HappenLee commented on code in PR #43777:
URL: https://github.com/apache/doris/pull/43777#discussion_r1839352612
##########
be/src/vec/aggregate_functions/aggregate_function_stddev.h:
##########
@@ -210,14 +195,7 @@ class AggregateFunctionSampVariance
if constexpr (is_pop) {
this->data(place).add(columns[0], row_num);
} else {
- if constexpr (is_nullable) { //this if check could remove with old
function
- const auto* nullable_column =
check_and_get_column<ColumnNullable>(columns[0]);
- if (!nullable_column->is_null_at(row_num)) {
-
this->data(place).add(&nullable_column->get_nested_column(), row_num);
- }
- } else {
- this->data(place).add(columns[0], row_num);
- }
+ this->data(place).add(columns[0], row_num);
Review Comment:
so why we need if?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
