HappenLee commented on code in PR #9505:
URL: https://github.com/apache/incubator-doris/pull/9505#discussion_r870264705
##########
be/src/exec/broker_scanner.cpp:
##########
@@ -158,53 +143,11 @@ Status BrokerScanner::open_file_reader() {
_skip_lines = 2;
}
}
- switch (range.file_type) {
- case TFileType::FILE_LOCAL: {
- LocalFileReader* file_reader = new LocalFileReader(range.path,
start_offset);
- RETURN_IF_ERROR(file_reader->open());
- _cur_file_reader = file_reader;
- break;
- }
- case TFileType::FILE_HDFS: {
- FileReader* hdfs_file_reader;
- RETURN_IF_ERROR(HdfsReaderWriter::create_reader(range.hdfs_params,
range.path, start_offset,
- &hdfs_file_reader));
- BufferedReader* file_reader = new BufferedReader(_profile,
hdfs_file_reader);
- RETURN_IF_ERROR(file_reader->open());
- _cur_file_reader = file_reader;
- break;
- }
- case TFileType::FILE_BROKER: {
- BrokerReader* broker_reader =
- new BrokerReader(_state->exec_env(), _broker_addresses,
_params.properties,
- range.path, start_offset);
- RETURN_IF_ERROR(broker_reader->open());
- _cur_file_reader = broker_reader;
- break;
- }
- case TFileType::FILE_S3: {
- BufferedReader* s3_reader = new BufferedReader(
- _profile, new S3Reader(_params.properties, range.path,
start_offset));
- RETURN_IF_ERROR(s3_reader->open());
- _cur_file_reader = s3_reader;
- break;
- }
- case TFileType::FILE_STREAM: {
- _stream_load_pipe =
_state->exec_env()->load_stream_mgr()->get(range.load_id);
- if (_stream_load_pipe == nullptr) {
- VLOG_NOTICE << "unknown stream load id: " <<
UniqueId(range.load_id);
- return Status::InternalError("unknown stream load id");
- }
- _cur_file_reader = _stream_load_pipe.get();
- break;
- }
- default: {
- std::stringstream ss;
- ss << "Unknown file type, type=" << range.file_type;
- return Status::InternalError(ss.str());
- }
- }
- return Status::OK();
+
+ RETURN_IF_ERROR(FileFactory::create_file_reader(range.file_type,
_state->exec_env(),
+ _broker_addresses,
_params.properties, range,
+ start_offset,
_cur_file_reader));
Review Comment:
origin code seems do not have the logic？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
