EmmyMiao87 commented on code in PR #9506:
URL: https://github.com/apache/incubator-doris/pull/9506#discussion_r870418900
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/pattern/Patterns.java:
##########
@@ -329,33 +328,31 @@ default PatternDescriptor<SlotReference, Expression>
slotReference() {
}
/**
- * create a binaryPredicate pattern.
+ * TODO create a ComparisonPredicate pattern.
*/
- default PatternDescriptor<BinaryPredicate<Expression, Expression>,
Expression> binaryPredicate() {
- return new PatternDescriptor<>(
- new Pattern<>(NodeType.BINARY_PREDICATE),
- defaultPromise()
- );
- }
/**
- * create a binaryPredicate pattern with operator type.
+ * TODO create a ComparisonPredicate pattern with children patterns.
*/
- default PatternDescriptor<BinaryPredicate<Expression, Expression>,
Expression> binaryPredicate(Operator operator) {
- return new PatternDescriptor<BinaryPredicate<Expression, Expression>,
Expression>(
- new Pattern<>(NodeType.BINARY_PREDICATE),
+
+ /**
+ * create a equal to predicate pattern.
+ */
+ default PatternDescriptor<EqualTo<Expression, Expression>, Expression>
eqcomparisonPredicate() {
Review Comment:
done
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/NodeType.java:
##########
@@ -43,7 +43,15 @@ public enum NodeType {
UNBOUND_STAR,
LITERAL,
SLOT_REFERENCE,
- BINARY_PREDICATE,
+ COMPARISON_PREDICATE,
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
