starocean999 commented on code in PR #42979:
URL: https://github.com/apache/doris/pull/42979#discussion_r1843150004
##########
fe/fe-core/src/main/java/org/apache/doris/blockrule/SqlBlockRuleMgr.java:
##########
@@ -90,6 +91,21 @@ public List<SqlBlockRule>
getSqlBlockRule(ShowSqlBlockRuleStmt stmt) throws Anal
return Lists.newArrayList(nameToSqlBlockRuleMap.values());
}
+ /**
+ * Get SqlBlockRule by show command.
+ **/
+ public List<SqlBlockRule> getSqlBlockRule(ShowSqlBlockRuleCommand cmd)
throws AnalysisException {
Review Comment:
better to use String as parameter and change the old code to call the new
function to remove duplicate code
```suggestion
public List<SqlBlockRule> getSqlBlockRule(String ruleName) throws
AnalysisException {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
