[GitHub] [incubator-doris] platoneko opened a new issue, #9513: [Enhancement] Confusing log messages from some if branches when check `Status`

[GitBox]

platoneko opened a new issue, #9513:
URL: https://github.com/apache/incubator-doris/issues/9513

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### Description
   
   Currently, `OLAPInternalError` will catch the exception stack, however in 
some cases these stack messages can be confusing:
   <img width="582" alt="image" 
src="https://user-images.githubusercontent.com/36853835/167892890-02375d1d-302b-48de-9098-1e9da6629f92.png";>
   While running the above code, even if the status returned is ok, 
`OLAPInternalError` is constructed in if condition, and it will capture the 
stack info. What's worse, Status::assemble_state() will print a WARNING log, 
though there is no exception `Status`:
   <img width="633" alt="image" 
src="https://user-images.githubusercontent.com/36853835/167893722-273e9920-452c-4dd7-859c-3eff3193dfde.png";>
   
   
   ### Solution
   
   Check Status::precise_code instead of constructing `OLAPInternalError` in if 
condition.
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org