yixiutt opened a new pull request, #9518:
URL: https://github.com/apache/incubator-doris/pull/9518

   commit #9123 introduce the bug. bitshuffle page return error when
   page is full, so scalar column write cannot switch to next page, which make
   ordinal index is null when flush.
   
   All page builder should return ok when page full, and column writer procedure
   shoud be append_data, check is_page_full, switch to next page
   
   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem Summary:
   ScalarColumn write cannot switch to next page cause page builder return 
false when page full
   
   coredump is here:
       @     0x556a329945f9  google::LogMessageFatal::~LogMessageFatal()
       @     0x556a329945f9  google::LogMessageFatal::~LogMessageFatal()
       @     0x556a316d7677  doris::segment_v2::OrdinalIndexWriter::finish()
       @     0x556a309d6809  doris::FlushToken::_flush_memtable()
       @     0x556a309d6809  doris::FlushToken::_flush_memtable()
       @     0x556a316d7677  doris::segment_v2::OrdinalIndexWriter::finish()
       @     0x556a309d7590  std::_Function_handler<>::_M_invoke()
       @     0x556a309d7590  std::_Function_handler<>::_M_invoke()
       @     0x556a316d0c8e  
doris::segment_v2::ScalarColumnWriter::write_ordinal_index()
       @     0x556a316d0c8e  
doris::segment_v2::ScalarColumnWriter::write_ordinal_index()
       @     0x556a30d7cacd  doris::ThreadPool::dispatch_thread()
       @     0x556a30d7cacd  doris::ThreadPool::dispatch_thread()
       @     0x556a316724b5  doris::segment_v2::SegmentWriter::finalize()
       @     0x556a30d7733f  doris::Thread::supervise_thread()
       @     0x556a30d7733f  doris::Thread::supervise_thread()
       @     0x556a316724b5  doris::segment_v2::SegmentWriter::finalize()
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: (Yes/No/I Don't know)
   2. Has unit tests been added: (Yes/No/No Need)
   3. Has document been added or modified: (Yes/No/No Need)
   4. Does it need to update dependencies: (Yes/No)
   5. Are there any changes that cannot be rolled back: (Yes/No)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[[email protected]](mailto:[email protected]) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to