HappenLee commented on code in PR #9505:
URL: https://github.com/apache/incubator-doris/pull/9505#discussion_r870927981


##########
be/src/exec/broker_scanner.h:
##########
@@ -110,7 +110,7 @@ class BrokerScanner : public BaseScanner {
     int _line_delimiter_length;
 
     // Reader
-    FileReader* _cur_file_reader;
+    std::shared_ptr<FileReader> _cur_file_reader;

Review Comment:
   note the `std::shared_ptr<StreamLoadPipe> _stream_load_pipe;`, here use the 
shared_ptr, so now we can't not use other pointer to manage the lifetime of the 
`FileReader* _cur_file_reader;`. 
   only the `shared_ptr`
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to