This is an automated email from the ASF dual-hosted git repository.
eldenmoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 893e05a67a0 [Fix](ShortCircuit) fix open segments leading to bad
performace (#44073)
893e05a67a0 is described below
commit 893e05a67a0733f619fd7e87dcd2fcb16dddcf5d
Author: lihangyu <[email protected]>
AuthorDate: Sat Nov 16 22:31:33 2024 +0800
[Fix](ShortCircuit) fix open segments leading to bad performace (#44073)
No need need to open segments for all rowsets, only open in
`lookup_row_key` stage.
Introduced by #42697
---
be/src/service/point_query_executor.cpp | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/be/src/service/point_query_executor.cpp
b/be/src/service/point_query_executor.cpp
index 74dab466340..ea991e158a1 100644
--- a/be/src/service/point_query_executor.cpp
+++ b/be/src/service/point_query_executor.cpp
@@ -396,17 +396,6 @@ Status PointQueryExecutor::_lookup_row_key() {
specified_rowsets = _tablet->get_rowset_by_ids(nullptr);
}
std::vector<std::unique_ptr<SegmentCacheHandle>>
segment_caches(specified_rowsets.size());
- // init segment_cache
- {
- SCOPED_TIMER(&_profile_metrics.load_segment_key_stage_ns);
- for (size_t i = 0; i < specified_rowsets.size(); i++) {
- auto& rs = specified_rowsets[i];
- segment_caches[i] = std::make_unique<SegmentCacheHandle>();
- RETURN_IF_ERROR(SegmentLoader::instance()->load_segments(
- std::static_pointer_cast<BetaRowset>(rs),
segment_caches[i].get(), true, true,
- &_profile_metrics.read_stats));
- }
- }
for (size_t i = 0; i < _row_read_ctxs.size(); ++i) {
RowLocation location;
if (!config::disable_storage_row_cache) {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
