cambyzju commented on code in PR #9527:
URL: https://github.com/apache/incubator-doris/pull/9527#discussion_r871945229


##########
fe/fe-core/src/main/java/org/apache/doris/load/Load.java:
##########
@@ -1064,6 +1064,12 @@ private static void initColumns(Table tbl, 
List<ImportColumnDesc> columnExprs,
                 // which is not nullable.
                 slotDesc.setIsNullable(true);
                 slotDesc.setColumn(new Column(realColName, 
PrimitiveType.VARCHAR));
+
+                boolean isBitmapType = 
tbl.getColumn(columnName).getType().isBitmapType();
+                if(isBitmapType){

Review Comment:
   I think it is better to change the code logic like: if (isBitmapType) { xxx 
} else { xxx }.
   Then we could sure functions like, setIsMaterialized and setIsNullable and 
so on, are called as expected.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to