cambyzju commented on code in PR #9541:
URL: https://github.com/apache/incubator-doris/pull/9541#discussion_r871983000
##########
be/src/vec/data_types/data_type_factory.cpp:
##########
@@ -260,4 +260,67 @@ DataTypePtr DataTypeFactory::create_data_type(const
PColumnMeta& pcolumn) {
return nested;
}
+DataTypePtr DataTypeFactory::create_data_type(const arrow::Type::type& type,
bool is_nullable) {
Review Comment:
Please pass arrow::DataType as input args to avoid refractor later, because
complex types create need children info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
