msridhar78 commented on code in PR #43469:
URL: https://github.com/apache/doris/pull/43469#discussion_r1847815017
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/source/HiveScanNode.java:
##########
@@ -364,14 +364,20 @@ public TableIf getTargetTable() {
@Override
public TFileFormatType getFileFormatType() throws UserException {
TFileFormatType type = null;
- String inputFormatName =
hmsTable.getRemoteTable().getSd().getInputFormat();
+ Table table = hmsTable.getRemoteTable();
+ String inputFormatName = table.getSd().getInputFormat();
String hiveFormat =
HiveMetaStoreClientHelper.HiveFileFormat.getFormat(inputFormatName);
if
(hiveFormat.equals(HiveMetaStoreClientHelper.HiveFileFormat.PARQUET.getDesc()))
{
type = TFileFormatType.FORMAT_PARQUET;
} else if
(hiveFormat.equals(HiveMetaStoreClientHelper.HiveFileFormat.ORC.getDesc())) {
type = TFileFormatType.FORMAT_ORC;
} else if
(hiveFormat.equals(HiveMetaStoreClientHelper.HiveFileFormat.TEXT_FILE.getDesc()))
{
- type = TFileFormatType.FORMAT_CSV_PLAIN;
+ String serDeLib =
table.getSd().getSerdeInfo().getSerializationLib();
+ if (serDeLib.equals("org.apache.hive.hcatalog.data.JsonSerDe")) {
Review Comment:
Will it be better to check if serDeLib.contains("JsonSerDe") as there can be
other imports for JsonSerDe lib like org.apache.hadoop.hive.serde2.JsonSerDe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
