yiguolei commented on code in PR #9547:
URL: https://github.com/apache/incubator-doris/pull/9547#discussion_r872905075
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -815,8 +816,10 @@ void SegmentIterator::_init_current_block(
void SegmentIterator::_output_non_pred_columns(vectorized::Block* block) {
SCOPED_RAW_TIMER(&_opts.stats->output_col_ns);
for (auto cid : _non_predicate_columns) {
- block->replace_by_position(_schema_block_id_map[cid],
- std::move(_current_return_columns[cid]));
+ auto loc = _schema_block_id_map[cid];
Review Comment:
std::vector<int> _schema_block_id_map; It is a map from schema column id to
column idx in Block, so all loc should less than block->columns(), why do we
need add this check?
If we need add this check, any else clause needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
