yiguolei commented on code in PR #9569:
URL: https://github.com/apache/incubator-doris/pull/9569#discussion_r873051414
##########
be/src/olap/memtable.cpp:
##########
@@ -302,7 +302,7 @@ Status MemTable::_do_flush(int64_t& duration_ns) {
}
} else {
vectorized::Block block = _collect_vskiplist_results();
- RETURN_NOT_OK(_rowset_writer->add_block(&block));
+ RETURN_NOT_OK(_rowset_writer->flush_single_memtable(&block));
_flush_size = block.allocated_bytes();
RETURN_NOT_OK(_rowset_writer->flush());
Review Comment:
flush method is flushing _segment_writer, not the writer created in
flush_single_memtable, maybe we could call flush(segment writer) at
flush_single_memtable method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
