dataroaring commented on code in PR #9586:
URL: https://github.com/apache/incubator-doris/pull/9586#discussion_r873369217
##########
be/src/vec/columns/column_dictionary.h:
##########
@@ -98,12 +98,14 @@ class ColumnDictionary final : public COWHelper<IColumn,
ColumnDictionary<T>> {
}
void insert_data(const char* pos, size_t /*length*/) override {
- _codes.push_back(unaligned_load<T>(pos));
+ if (pos == nullptr) {
+ _codes.push_back(_dict.get_null_code());
+ return;
+ }
+ LOG(FATAL) << "insert_data not supported in ColumnDictionary";
Review Comment:
Should we place a DCHECK(false) here？
##########
be/src/vec/columns/column_dictionary.h:
##########
@@ -304,10 +310,14 @@ class ColumnDictionary final : public COWHelper<IColumn,
ColumnDictionary<T>> {
return -1;
}
+ T get_null_code() {
+ return _dict_data.size() - 1; // The last dict value is null value
+ }
Review Comment:
For range predicate, it seems related to null order, I am not sure how doris
handle null order. e.g. where col >= "xxx" includes null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
