airborne12 commented on code in PR #44397:
URL: https://github.com/apache/doris/pull/44397#discussion_r1852064038
##########
be/test/olap/rowset/segment_v2/bloom_filter_index_reader_writer_test.cpp:
##########
@@ -59,40 +59,46 @@ class BloomFilterIndexReaderWriterTest : public
testing::Test {
};
template <FieldType type>
-void write_bloom_filter_index_file(const std::string& file_name, const void*
values,
- size_t value_count, size_t null_count,
- ColumnIndexMetaPB* index_meta) {
+Status write_bloom_filter_index_file(const std::string& file_name, const void*
values,
Review Comment:
write_bloom_filter_index_file is an UT function, when create primary key bf
read/write test we set use_primary_key_bloom_filter true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
