jacktengg commented on code in PR #43296:
URL: https://github.com/apache/doris/pull/43296#discussion_r1852312005
##########
be/src/vec/functions/round.h:
##########
@@ -164,8 +170,8 @@ class DecimalRoundingImpl {
public:
static NO_INLINE void apply(const Container& in, UInt32 in_scale,
Container& out,
Review Comment:
Because for e.g. in line 656 it's called with type `int32_t`:
```
DecimalRoundingImpl<T, rounding_mode,
tie_breaking_mode>::apply(
decimal_col->get_element(i).value, input_scale,
col_res->get_element(i).value,
col_scale_i32.get_data()[i]);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
