jackwener commented on code in PR #9598:
URL: https://github.com/apache/incubator-doris/pull/9598#discussion_r874554933
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/join/JoinCommutative.java:
##########
@@ -15,28 +15,43 @@
// specific language governing permissions and limitations
// under the License.
-package org.apache.doris.nereids.rules.exploration;
+package org.apache.doris.nereids.rules.exploration.join;
import org.apache.doris.nereids.rules.Rule;
import org.apache.doris.nereids.rules.RuleType;
-import org.apache.doris.nereids.trees.plans.JoinType;
+import org.apache.doris.nereids.rules.exploration.OneExplorationRuleFactory;
import org.apache.doris.nereids.trees.plans.Plan;
import org.apache.doris.nereids.trees.plans.logical.LogicalJoin;
/**
* rule factory for exchange inner join's children.
*/
public class JoinCommutative extends OneExplorationRuleFactory {
+ private boolean justApplyInnerOuterCrossJoin = false;
+
+ private final SwapType swapType;
+
+ /**
+ * If param is true, just apply rule in inner/full-outer/cross join.
+ */
+ public JoinCommutative(boolean justApplyInnerOuterCrossJoin) {
+ this.justApplyInnerOuterCrossJoin = justApplyInnerOuterCrossJoin;
+ this.swapType = SwapType.ALL;
Review Comment:
limit swap space, we should change `JoinReorderContext ` according to it
- left deep tree -> swap bottom join and disable l-asscom
- zig-zag ...
- busy...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
