github-actions[bot] commented on code in PR #41232:
URL: https://github.com/apache/doris/pull/41232#discussion_r1855988706
##########
be/src/olap/partial_update_info.h:
##########
@@ -19,6 +19,7 @@
#include <gen_cpp/olap_file.pb.h>
Review Comment:
warning: 'gen_cpp/olap_file.pb.h' file not found [clang-diagnostic-error]
```cpp
#include <gen_cpp/olap_file.pb.h>
^
```
##########
be/src/olap/partial_update_info.cpp:
##########
@@ -169,55 +175,53 @@ std::string PartialUpdateInfo::summary() const {
max_version_in_flush_phase);
}
-Status PartialUpdateInfo::handle_not_found_error_for_fixed_partial_update(
- const TabletSchema& tablet_schema) const {
- if (!can_insert_new_rows_in_partial_update) {
- std::string error_column;
- for (auto cid : missing_cids) {
- const TabletColumn& col = tablet_schema.column(cid);
- if (!col.has_default_value() && !col.is_nullable() &&
- !(tablet_schema.auto_increment_column() == col.name())) {
- error_column = col.name();
- break;
+Status PartialUpdateInfo::handle_new_key(const TabletSchema& tablet_schema,
Review Comment:
warning: method 'handle_new_key' can be made const
[readability-make-member-function-const]
be/src/olap/partial_update_info.cpp:178:
```diff
- BitmapValue* skip_bitmap) {
+ BitmapValue* skip_bitmap) const {
```
be/src/olap/partial_update_info.h:52:
```diff
- Status handle_new_key(const TabletSchema& tablet_schema, BitmapValue*
skip_bitmap = nullptr);
+ Status handle_new_key(const TabletSchema& tablet_schema, BitmapValue*
skip_bitmap = nullptr) const;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
