xinyiZzz commented on code in PR #9521:
URL: https://github.com/apache/incubator-doris/pull/9521#discussion_r874550846
##########
be/src/olap/lru_cache.cpp:
##########
@@ -106,40 +103,38 @@ LRUHandle* HandleTable::remove(const CacheKey& key,
uint32_t hash) {
LRUHandle** ptr = _find_pointer(key, hash);
LRUHandle* result = *ptr;
- remove(result);
+ if (result != nullptr) {
+ *ptr = result->next_hash;
+ _elems--;
+ }
return result;
}
-void HandleTable::remove(const LRUHandle* h) {
- if (h != nullptr) {
- if (h->next_hash != nullptr) {
- h->next_hash->prev_hash = h->prev_hash;
- }
- DCHECK(h->prev_hash != nullptr);
- h->prev_hash->next_hash = h->next_hash;
- --_elems;
+bool HandleTable::remove(const LRUHandle* h) {
+ LRUHandle** ptr = &(_list[h->hash & (_length - 1)]);
+ while (*ptr != nullptr && *ptr != h) {
+ ptr = &(*ptr)->next_hash;
}
+
+ LRUHandle* result = *ptr;
Review Comment:
You're right~, I see you optimize the code logic at the same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
