morrySnow commented on code in PR #44365:
URL: https://github.com/apache/doris/pull/44365#discussion_r1857699390
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/SubExprAnalyzer.java:
##########
@@ -205,17 +204,15 @@ private AnalyzedResult analyzeSubquery(SubqueryExpr expr)
{
}
CascadesContext subqueryContext =
CascadesContext.newContextWithCteContext(
cascadesContext, expr.getQueryPlan(),
cascadesContext.getCteContext());
- Scope subqueryScope = genScopeWithSubquery(expr);
+ Scope subqueryScope = genScopeWithSubquery();
Review Comment:
could be replace by `getScope()`
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/SubExprAnalyzer.java:
##########
@@ -205,17 +204,15 @@ private AnalyzedResult analyzeSubquery(SubqueryExpr expr)
{
}
CascadesContext subqueryContext =
CascadesContext.newContextWithCteContext(
cascadesContext, expr.getQueryPlan(),
cascadesContext.getCteContext());
- Scope subqueryScope = genScopeWithSubquery(expr);
+ Scope subqueryScope = genScopeWithSubquery();
subqueryContext.setOuterScope(subqueryScope);
subqueryContext.newAnalyzer().analyze();
return new AnalyzedResult((LogicalPlan)
subqueryContext.getRewritePlan(),
subqueryScope.getCorrelatedSlots());
}
- private Scope genScopeWithSubquery(SubqueryExpr expr) {
Review Comment:
could be removed because it is same with getScope()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
