xzj7019 opened a new pull request, #44617: URL: https://github.com/apache/doris/pull/44617
### What problem does this PR solve? Related PR: https://github.com/apache/doris/pull/38393 Problem Summary: In the previous pr which supporting multi win expr ptopN pushdown, it handled partial forbidden type unexpectly and will lead some case to push down the pTopN wrongly. plan before fixing: `mysql> explain shape plan select * from (select row_number() over(partition by c1, c2 order by c3) as rn, sum(c2) over(order by c2 range between unbounded preceding and unbounded following) as sw from push_down_multi_predicate_through_window_t) t where rn <= 1 and sw <= 1; +------------------------------------------------------------------------------------+ | Explain String(Nereids Planner) | +------------------------------------------------------------------------------------+ | PhysicalResultSink | | --PhysicalProject | | ----filter((rn <= 1) and (sw <= 1)) | | ------PhysicalWindow | | --------PhysicalQuickSort[MERGE_SORT] | | ----------PhysicalDistribute[DistributionSpecGather] | | ------------PhysicalQuickSort[LOCAL_SORT] | | --------------PhysicalWindow | | ----------------PhysicalQuickSort[LOCAL_SORT] | | ------------------PhysicalDistribute[DistributionSpecHash] | | --------------------PhysicalPartitionTopN | | ----------------------PhysicalOlapScan[push_down_multi_predicate_through_window_t] | +------------------------------------------------------------------------------------+` plan after fixing: `mysql> explain shape plan select * from (select row_number() over(partition by c1, c2 order by c3) as rn, sum(c2) over(order by c2 range between unbounded preceding and unbounded following) as sw from push_down_multi_predicate_through_window_t) t where rn <= 1 and sw <= 1; +----------------------------------------------------------------------------------+ | Explain String(Nereids Planner) | +----------------------------------------------------------------------------------+ | PhysicalResultSink | | --PhysicalProject | | ----filter((rn <= 1) and (sw <= 1)) | | ------PhysicalWindow | | --------PhysicalQuickSort[MERGE_SORT] | | ----------PhysicalDistribute[DistributionSpecGather] | | ------------PhysicalQuickSort[LOCAL_SORT] | | --------------PhysicalWindow | | ----------------PhysicalQuickSort[LOCAL_SORT] | | ------------------PhysicalDistribute[DistributionSpecHash] | | --------------------PhysicalOlapScan[push_down_multi_predicate_through_window_t] | +----------------------------------------------------------------------------------+` ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
