carlvinhust2012 commented on code in PR #9666:
URL: https://github.com/apache/incubator-doris/pull/9666#discussion_r876556821
##########
be/src/vec/core/block.cpp:
##########
@@ -402,6 +402,20 @@ std::string Block::dump_data(size_t begin, size_t
row_limit) const {
return out.str();
}
+std::string Block::dump_one_line(size_t row, int column_end) const {
+ assert(column_end < columns());
+ fmt::memory_buffer line;
+ for (int i = 0; i < column_end; ++i) {
+ if (LIKELY(i != 0)) {
+ // TODO: need more effective function of to string. now the impl
is slow
+ fmt::format_to(line, " {}", data[i].to_string(row));
Review Comment:
why not check whether the data[i] is validity like this " if
(data[i].column) { s = data[i].to_string(row_num); } " ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
