Gabriel39 commented on code in PR #9663:
URL: https://github.com/apache/incubator-doris/pull/9663#discussion_r877852699
##########
be/src/vec/common/columns_hashing_impl.h:
##########
@@ -132,12 +132,25 @@ class HashMethodBase {
return emplaceImpl(key_holder, data);
}
+ template <typename Data>
+ ALWAYS_INLINE EmplaceResult emplace_key(Data& data, size_t row, size_t
hash_value,
+ Arena& pool) {
+ auto key_holder = static_cast<Derived&>(*this).get_key_holder(row,
pool);
Review Comment:
`get_key_holder` will cause memory copy for join keys. But this copy happens
twice which will hurt performance. First we copy the keys to compute hash value
for it and then emplace_key here which also copies keys. We should simplify
this behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
