morrySnow commented on code in PR #44732: URL: https://github.com/apache/doris/pull/44732#discussion_r1867249340
########## regression-test/data/nereids_rules_p0/infer_predicate/pull_up_predicate_literal.out: ########## @@ -262,15 +262,7 @@ PhysicalResultSink -- !const_value_and_join_column_type16 -- PhysicalResultSink ---PhysicalProject -----hashJoin[INNER_JOIN] hashCondition=((expr_cast(d_tinyint as SMALLINT) = t.c1)) otherCondition=() -------PhysicalLimit[GLOBAL] ---------PhysicalLimit[LOCAL] -----------PhysicalProject -------------PhysicalStorageLayerAggregate[test_pull_up_predicate_literal] -------PhysicalProject Review Comment: maybe we should modify pull up's case to ensure not generate PhysicalEmptyRelation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
