gavinchou commented on code in PR #44691:
URL: https://github.com/apache/doris/pull/44691#discussion_r1867890714
##########
cloud/src/meta-service/meta_service_tablet_stats.cpp:
##########
@@ -36,7 +36,8 @@
namespace doris::cloud {
-void internal_get_tablet_stats(MetaServiceCode& code, std::string& msg,
Transaction* txn,
+void internal_get_tablet_stats(MetaServiceCode& code, std::string& msg,
+ std::unique_ptr<Transaction>& txn,
std::shared_ptr<TxnKv>& txn_kv,
Review Comment:
This is a behavior change, semantic changed, txn atomic is not garanteed if
we create a new txn.
Fix where this `internal_get_tablet_stats()` is called if we met
TXN_TOO_OLD
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
