qidaye commented on code in PR #9658:
URL: https://github.com/apache/incubator-doris/pull/9658#discussion_r879153705
##########
docs/en/ecosystem/external-table/iceberg-of-doris.md:
##########
@@ -135,10 +167,15 @@ You can also create an Iceberg table by explicitly
specifying the column definit
- The order of the columns needs to be consistent with the Iceberg table
- ENGINE needs to be specified as ICEBERG
- PROPERTIES property.
- - `iceberg.hive.metastore.uris`: Hive Metastore service address
- `iceberg.database`: the name of the database to which Iceberg is mounted
- `iceberg.table`: the name of the table to which Iceberg is mounted, not
required when mounting Iceberg database.
- - `iceberg.catalog.type`: the catalog method used in Iceberg, the default
is `HIVE_CATALOG`, currently only this method is supported, more Iceberg
catalog access methods will be supported in the future.
+ - `iceberg.catalog.type`: the catalog type used in Iceberg, the default is
`HIVE` (simple name of `org.apache.iceberg.hive.HiveCatalog`).
Review Comment:
`type` only supports `HIVE` and `HADOOP`.
Other types of catalog should use `catalog-impl` config. We should make it
clear for users.
##########
docs/en/ecosystem/external-table/iceberg-of-doris.md:
##########
@@ -135,10 +167,15 @@ You can also create an Iceberg table by explicitly
specifying the column definit
- The order of the columns needs to be consistent with the Iceberg table
- ENGINE needs to be specified as ICEBERG
- PROPERTIES property.
- - `iceberg.hive.metastore.uris`: Hive Metastore service address
- `iceberg.database`: the name of the database to which Iceberg is mounted
- `iceberg.table`: the name of the table to which Iceberg is mounted, not
required when mounting Iceberg database.
- - `iceberg.catalog.type`: the catalog method used in Iceberg, the default
is `HIVE_CATALOG`, currently only this method is supported, more Iceberg
catalog access methods will be supported in the future.
+ - `iceberg.catalog.type`: the catalog type used in Iceberg, the default is
`HIVE` (simple name of `org.apache.iceberg.hive.HiveCatalog`).
+ - `iceberg.catalog.catalog-impl`: you could also use the full catalog name
with this property. You should not use both `iceberg.catalog.type` and
`iceberg.catalog.catalog-impl`.
Review Comment:
The user does not need to care about the specific implementation classes of
the catalog already supported in iceberg, which would make it more difficult to
use. Such as `JDBC`/`Glue` and so on.
User only needs to set the catalog type and the specific implementation
class Doris should encapsulate it.
Wouldn't it be better if the user only needs to set the implementation class
information when using a custom catalog?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
