yiguolei commented on code in PR #9771:
URL: https://github.com/apache/incubator-doris/pull/9771#discussion_r881545905
##########
be/src/util/json_util.cpp:
##########
@@ -32,11 +32,7 @@ std::string to_json(const Status& status) {
writer.StartObject();
// status
writer.Key("status");
- if (status.ok()) {
Review Comment:
Hi jack, I think we could move to_json(Status& status) method to
common/status.h since there is only one method in this file and it is related
with common/status.
And also you could remove json_util_test.h because we could not ensure that
the error message always the same with the expected string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
