jackwener commented on code in PR #9822:
URL: https://github.com/apache/incubator-doris/pull/9822#discussion_r884078005
##########
fe/fe-core/src/main/java/org/apache/doris/backup/AbstractJob.java:
##########
@@ -87,7 +87,7 @@ protected AbstractJob(JobType type, String label, long dbId,
String dbName,
this.label = label;
this.dbId = dbId;
this.dbName = dbName;
- this.createTime = System.currentTimeMillis();
Review Comment:
I think `this.` in constructor can remain.
Because I think it's better to keep same style.
##########
fe/fe-core/src/main/java/org/apache/doris/backup/Repository.java:
##########
@@ -119,7 +119,7 @@ public Repository(long id, String name, boolean isReadOnly,
String location, Blo
this.isReadOnly = isReadOnly;
this.location = location;
this.storage = storage;
- this.createTime = System.currentTimeMillis();
Review Comment:
same with above.
##########
fe/fe-core/src/main/java/org/apache/doris/backup/BackupJob.java:
##########
@@ -124,7 +124,7 @@ public BackupJob(String label, long dbId, String dbName,
List<TableRef> tableRef
BackupContent content, Catalog catalog, long repoId) {
super(JobType.BACKUP, label, dbId, dbName, timeoutMs, catalog, repoId);
this.tableRefs = tableRefs;
- this.state = BackupJobState.PENDING;
Review Comment:
same with above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
