yiguolei commented on code in PR #45410:
URL: https://github.com/apache/doris/pull/45410#discussion_r1886003119
##########
be/src/vec/common/columns_hashing.h:
##########
@@ -152,8 +152,12 @@ struct HashMethodSingleLowNullableColumn : public
SingleColumnMethod {
template <typename Data, typename Key>
ALWAYS_INLINE FindResult find_key_with_hash(Data& data, size_t i, Key key,
size_t hash_value) {
- if (key_column->is_null_at(i) && data.has_null_key_data()) {
- return FindResult {&data.template get_null_key_data<Mapped>(),
true};
+ if (key_column->is_null_at(i)) {
+ if (data.has_null_key_data()) {
+ return FindResult {&data.template get_null_key_data<Mapped>(),
true};
Review Comment:
之前是有什么bug 吗？
##########
be/src/vec/functions/function_string.h:
##########
@@ -702,6 +702,8 @@ class FunctionMask : public IFunction {
size_t get_number_of_arguments() const override { return 0; }
+ ColumnNumbers get_arguments_that_are_always_constant() const override {
return {1, 2, 3}; }
Review Comment:
之前是有什么bug吗
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
