github-actions[bot] commented on code in PR #45680:
URL: https://github.com/apache/doris/pull/45680#discussion_r1892752108
##########
be/src/olap/rowset/segment_v2/variant_column_writer_impl.cpp:
##########
@@ -333,10 +344,10 @@ uint64_t VariantColumnWriterImpl::estimate_buffer_size() {
return _column->byte_size();
}
uint64_t size = 0;
+ size += _root_writer->estimate_buffer_size();
Review Comment:
warning: method 'estimate_buffer_size' can be made const
[readability-make-member-function-const]
```suggestion
uint64_t VariantColumnWriterImpl::estimate_buffer_size() const {
```
be/src/olap/rowset/segment_v2/variant_column_writer_impl.h:63:
```diff
- uint64_t estimate_buffer_size();
+ uint64_t estimate_buffer_size() const;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
