stalary commented on code in PR #9895:
URL: https://github.com/apache/incubator-doris/pull/9895#discussion_r888989339
##########
fe/fe-core/src/main/java/org/apache/doris/external/elasticsearch/EsUtil.java:
##########
@@ -87,12 +105,134 @@ public static JSONObject getJsonObject(JSONObject
jsonObject, String key, int fr
}
}
+ /**
+ * Wrapper for get boolean value.
+ **/
public static boolean getBoolean(Map<String, String> properties, String
name) throws DdlException {
String property = properties.get(name).trim();
try {
return Boolean.parseBoolean(property);
} catch (Exception e) {
- throw new DdlException(String.format("fail to parse %s, %s = %s,
`%s` should be like 'true' or 'false'， value should be double quotation marks",
name, name, property, name));
+ throw new DdlException(String.format("fail to parse %s, %s = %s,
`%s` should be like 'true' or 'false'， "
+ + "value should be double quotation marks", name, name,
property, name));
+ }
+ }
+
+ /**
+ * Doris expr to es dsl.
+ **/
+ public static QueryBuilder convertToEsDsl(Expr expr) {
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
