Gabriel39 commented on code in PR #9974:
URL: https://github.com/apache/incubator-doris/pull/9974#discussion_r890117550
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/BrokerMgr.java:
##########
@@ -368,8 +368,8 @@ public ModifyBrokerInfo() {
}
public ModifyBrokerInfo(String brokerName, List<FsBroker>
brokerAddresses) {
- this.brokerName = brokerName;
Review Comment:
Hi @whyy7777 , thanks for your contribution. Besides, I'm just wondering if
this programming convention is better than before. Could you give some
motivations for this PR? Maybe a programming convention adopted somewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
