Baymine opened a new pull request, #46099:
URL: https://github.com/apache/doris/pull/46099
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
- Currently, the SQL cache system in Doris may miss cache hits due to
semantically identical queries being treated as different because of:
- Extra whitespace characters in the SQL query
- SQL comments that don't affect the query execution
- For example, these queries are semantically identical but would generate
different cache keys:
```sql
SELECT * FROM table;
-- Same query with comments and extra spaces
/* Comment */ SELECT * FROM table ;
```
- This PR improves the SQL cache hit rate by:
- Trimming whitespace from SQL queries
- Removing SQL comments before calculating the cache key MD5
- This ensures that queries that are semantically identical but differ only
in whitespace or comments will now hit the same cache entry, improving cache
efficiency and reducing unnecessary query executions
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [x] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]