This is an automated email from the ASF dual-hosted git repository.
eldenmoon pushed a commit to branch variant-sparse
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/variant-sparse by this push:
new 35d63b80550 fix serialize (#46185)
35d63b80550 is described below
commit 35d63b805504bb14fffb67bac26e469bdb78e9d5
Author: lihangyu <[email protected]>
AuthorDate: Tue Dec 31 11:08:22 2024 +0800
fix serialize (#46185)
---
be/src/vec/columns/column_object.cpp | 2 +-
be/src/vec/data_types/serde/data_type_object_serde.cpp | 7 -------
2 files changed, 1 insertion(+), 8 deletions(-)
diff --git a/be/src/vec/columns/column_object.cpp
b/be/src/vec/columns/column_object.cpp
index 2ce8ce791ed..427515d1b6e 100644
--- a/be/src/vec/columns/column_object.cpp
+++ b/be/src/vec/columns/column_object.cpp
@@ -352,7 +352,7 @@ void get_field_info(const Field& field, FieldInfo* info) {
}
#ifdef NDEBUG
-#define ENABLE_CHECK_CONSISTENCY (void) /* Nothing */
+#define ENABLE_CHECK_CONSISTENCY (void)/* Nothing */
#else
#define ENABLE_CHECK_CONSISTENCY(this) (this)->check_consistency()
#endif
diff --git a/be/src/vec/data_types/serde/data_type_object_serde.cpp
b/be/src/vec/data_types/serde/data_type_object_serde.cpp
index 6c902b60589..2cb8bae915d 100644
--- a/be/src/vec/data_types/serde/data_type_object_serde.cpp
+++ b/be/src/vec/data_types/serde/data_type_object_serde.cpp
@@ -47,10 +47,6 @@ Status DataTypeObjectSerDe::_write_column_to_mysql(const
IColumn& column,
int64_t row_idx, bool
col_const,
const FormatOptions&
options) const {
const auto& variant = assert_cast<const ColumnObject&>(column);
- if (!variant.is_finalized()) {
- const_cast<ColumnObject&>(variant).finalize();
- }
- RETURN_IF_ERROR(variant.sanitize());
if (variant.is_scalar_variant()) {
// Serialize scalar types, like int, string, array, faster path
const auto& root = variant.get_subcolumn({});
@@ -90,9 +86,6 @@ void DataTypeObjectSerDe::write_one_cell_to_jsonb(const
IColumn& column, JsonbWr
Arena* mem_pool, int32_t
col_id,
int64_t row_num) const {
const auto& variant = assert_cast<const ColumnObject&>(column);
- if (!variant.is_finalized()) {
- const_cast<ColumnObject&>(variant).finalize();
- }
result.writeKey(cast_set<JsonbKeyValue::keyid_type>(col_id));
std::string value_str;
if (!variant.serialize_one_row_to_string(row_num, &value_str)) {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
