yangzhg commented on code in PR #9804:
URL: https://github.com/apache/incubator-doris/pull/9804#discussion_r893008941
##########
be/src/olap/tablet.cpp:
##########
@@ -870,10 +870,56 @@ void Tablet::calculate_cumulative_point() {
if (ret_cumulative_point == K_INVALID_CUMULATIVE_POINT) {
return;
}
-
set_cumulative_layer_point(ret_cumulative_point);
}
+//find rowsets that rows less then "config::small_compaction_max_rows"
+Status Tablet::pick_small_verson_rowsets(std::vector<RowsetSharedPtr>*
input_rowsets,
+ int64_t* permits) {
+ if (!init_succeeded()) {
+ return
Status::OLAPInternalError(OLAP_ERR_CUMULATIVE_INVALID_PARAMETERS);
+ }
+ int max_series_num = 1000;
+ int max_rows = config::small_compaction_max_rows;
+ if (max_rows <= 0) return Status::OK();
Review Comment:
```suggestion
if (max_rows <= 0) { return Status::OK(); }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
