gavinchou commented on code in PR #46221:
URL: https://github.com/apache/doris/pull/46221#discussion_r1900421718
##########
gensrc/proto/cloud.proto:
##########
@@ -1095,6 +1095,8 @@ message AlterClusterRequest {
optional string cloud_unique_id = 2; // For auth
optional ClusterPB cluster = 3;
optional Operation op = 4;
+ // for SQL mode rename cluster, rename to cluster name eq instance empty
cluster name, need drop empty cluster
+ optional bool drop_empty_cluster = 5 [default = false];
Review Comment:
do not use default semantic, just make it optional is enough.
suggest naming `replace_if_existing_empty_target_cluster`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
