yiguolei commented on code in PR #10016:
URL: https://github.com/apache/incubator-doris/pull/10016#discussion_r893059900
##########
be/src/olap/rowset/segment_v2/column_reader.cpp:
##########
@@ -659,20 +662,33 @@ Status FileColumnIterator::_read_data_page(const
OrdinalPageIndexIterator& iter)
Slice page_body;
PageFooterPB footer;
_opts.type = DATA_PAGE;
- RETURN_IF_ERROR(_reader->read_page(_opts, iter.page(), &handle,
&page_body, &footer,
- _compress_codec.get()));
- // parse data page
- RETURN_IF_ERROR(ParsedPage::create(std::move(handle), page_body,
footer.data_page_footer(),
- _reader->encoding_info(), iter.page(),
iter.page_index(),
- &_page));
+ auto reading_data_opts = _opts;
Review Comment:
You'd better add a comment here. Because you copied opts and opts has stats,
if it is not a ptr, then something may wrong. But currently, it is right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
